Formatting some comments in macro causes a -Wcomment errors like: from: ---- >>#define MAX_COLSPAN 1000 // limit as IE and opera do. If this ever changes, >> // change COL_SPAN_OFFSET/COL_SPAN_SHIFT accordingly. ---- to: ---- >>#define MAX_COLSPAN \ >> 1000 // limit as IE and opera do. If this ever changes, \ >> // change COL_SPAN_OFFSET/COL_SPAN_SHIFT accordingly. ---- warning treated: >> warning: multi-line comment [-Wcomment] The latest version of clang-format fixes the ReflowComments and also CommentPragmas options that cause this issue. I strongly think that we should permit ReflowComments and disallow the skipping of comment formatting by removing CommentPragmas.

Comment on attachment 8925463 [details] Bug 1414764 - Remove Mozilla specific options to avoid build warnings with gcc and -Wcomment enabled. https://reviewboard.mozilla.org/r/196586/#review201808

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again. hg error in cmd: hg rebase -s 4da9b8415b53 -d f43442328ed9: rebasing 432239:4da9b8415b53 "Bug 1414764 - Remove Mozilla specific options to avoid build warnings with gcc and -Wcomment enabled. r=sylvestre" (tip) merging .clang-format warning: conflicts while merging .clang-format! (edit, then use 'hg resolve --mark') unresolved conflicts (see hg resolve, then hg rebase --continue)

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again. hg error in cmd: hg rebase -s 4da9b8415b53 -d f43442328ed9: rebasing 432239:4da9b8415b53 "Bug 1414764 - Remove Mozilla specific options to avoid build warnings with gcc and -Wcomment enabled. r=sylvestre" (tip) merging .clang-format warning: conflicts while merging .clang-format! (edit, then use 'hg resolve --mark') unresolved conflicts (see hg resolve, then hg rebase --continue)

Pushed by bpostelnicu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c9e777a6f988 Remove Mozilla specific options to avoid build warnings with gcc and -Wcomment enabled. r=sylvestre